Skip to content

Conversation

Akshat453
Copy link
Contributor

@Akshat453 Akshat453 commented Aug 4, 2025

Fixes:#4759

Fixes from previous Pr : #2786
The function's signature in challengeCtrl.js was updated to accept a string phaseSlug as an argument instead of a numeric phaseId

Screen.Recording.2025-08-05.at.10.00.53.PM.mov

Akshat Singh added 2 commits August 4, 2025 22:54
@Akshat453
Copy link
Contributor Author

Hey @RishabhJain2018 Can you review the video i have uploaded i am fixing the build

Akshat Singh added 2 commits August 14, 2025 19:12
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.30%. Comparing base (96968d6) to head (0484cf9).
⚠️ Report is 1233 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4762      +/-   ##
==========================================
+ Coverage   72.93%   78.30%   +5.37%     
==========================================
  Files          83       21      -62     
  Lines        5368     3591    -1777     
==========================================
- Hits         3915     2812    -1103     
+ Misses       1453      779     -674     
Files with missing lines Coverage Δ
frontend/src/js/controllers/challengeCtrl.js 64.00% <ø> (-9.70%) ⬇️
...ontend/src/js/controllers/featuredChallengeCtrl.js 98.40% <100.00%> (+29.40%) ⬆️

... and 73 files with indirect coverage changes

Files with missing lines Coverage Δ
frontend/src/js/controllers/challengeCtrl.js 64.00% <ø> (-9.70%) ⬇️
...ontend/src/js/controllers/featuredChallengeCtrl.js 98.40% <100.00%> (+29.40%) ⬆️

... and 73 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e39f8...0484cf9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Akshat453 Akshat453 marked this pull request as ready for review August 15, 2025 02:19
@Akshat453
Copy link
Contributor Author

Hey @RishabhJain2018 Can you review this Pr ?

Akshat Singh added 2 commits August 15, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant