Fix Invoke-CCMSoftwareUpdate returning false status for successful invocations #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Invoke-CCMSoftwareUpdate
function was incorrectly returningInvoked = False
even when software update installations were successfully triggered. This issue occurred because the function usedif ($Invocation)
to determine success, which doesn't properly handle CIM method return values.Root Cause
The function was checking if the invocation result was truthy rather than examining the actual CIM method return code. This caused problems in several scenarios:
Invoke-CCMCommand
for remote computers, the function may return empty results even when the underlying CIM method succeededSolution
Updated the success detection logic to match the proven pattern used in
Invoke-CCMApplication
:This change ensures that:
ReturnValue = 0
(success) are considered successfulTesting
The fix has been validated against multiple scenarios including successful invocations, actual failures, null results, and remote execution edge cases.
Fixes #54.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.