Kafka upgrade

[shroffk]

Checklist

• Testing:

  • tested deploying on webpods and verified alarm servers default actions ( add/remove/modify configuration, generate alarms, ack/unack, enable/disable )

• Documentation:

  • The feature is documented
  • The documentation is up to date
  • Release notes:
    • Added an entry if the change is breaking or significant
    • Added an entry when adding a new feature

[shroffk]

I have update the alarm server startup so that it will create and properly configure the kafka topics based on the config_name

It basically does that things the create_alarm_topics.sh does... with the added benefit that we don't need to remind anyone.

Note:
I have tested that it create new ones and fixes existing topics... but would prefer a bit more looking into

[kasemir]

Good idea!

[kasemir]

As for "The feature is documented", it's documented that you need to call create_alarm_topics.sh, which is no longer the case.
That script can be removed. The documentation should probably mention that we rely on a "compacting" topic for the alarm config and state, and how that's done automatically by running the alarm server for the first time on a new config.

[georgweiss]

The kafka_props_file argument is not used in this method.

[georgweiss]

All seems to work as expected.

But I've added some comments.