Skip to content

move column visibility checks to a submenu #3608 #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

move column visibility checks to a submenu #3608 #3610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/ui/src/main/java/org/phoebus/ui/application/TableHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import javafx.collections.ObservableList;
import javafx.scene.control.CheckMenuItem;
import javafx.scene.control.ContextMenu;
import javafx.scene.control.Menu;
import javafx.scene.control.MenuItem;
import javafx.scene.control.TableColumn;
import javafx.scene.control.TableView;
import org.phoebus.framework.persistence.Memento;
Expand All @@ -15,17 +17,19 @@ public class TableHelper {
* */
public static boolean addContextMenuColumnVisibilityEntries(final TableView<?> table, final ContextMenu menu) {
boolean added_item = false;
Menu visibilitySubMenu = new Menu("Column Visibility");
for (TableColumn<?, ?> col : table.getColumns()) {
if (col.getText().isEmpty()) continue;
CheckMenuItem item = new CheckMenuItem("Show " + col.getText());
item.selectedProperty().bindBidirectional(col.visibleProperty());
menu.getItems().add(item);
visibilitySubMenu.getItems().add(item);
added_item = true;
}
if (added_item)
menu.getItems().add(visibilitySubMenu);
return added_item;
}


/** Save column visibilities to a memento
* */
public static <T> void saveColumnVisibilities(
Expand Down