Skip to content

CSSTUDIO-3537 Bugfix: Fix check for non-zero-length array (For ESS-specific navigator) #3616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

CSSTUDIO-3537 Bugfix: Fix check for non-zero-length array (For ESS-specific navigator) #3616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/ui/src/main/java/org/phoebus/ui/docking/DockPane.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ else if (dock_parent instanceof SplitPane) // "dock_parent instanceof SplitPane"
final SplitPane parent = (SplitPane) dock_parent;
// Remove this dock pane from BorderPane
Optional<Double> dividerPosition;
if (parent.getDividerPositions().length > 1) {
if (parent.getDividerPositions().length > 0) {
Copy link
Contributor

@jacomago jacomago Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use Arrays.isNullOrEmpty

dividerPosition = Optional.of(parent.getDividerPositions()[0]);
}
else {
Expand Down