Skip to content

feat: set devDependencies component.scope to excluded #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: set devDependencies component.scope to excluded #1374

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
89bfd95
Bom Issue Fixed
AradhyaTiwari10 Oct 28, 2025
ed53d46
Restore src/builders.ts after accidental deletion
AradhyaTiwari10 Oct 28, 2025
298f07e
test: update snapshots for reproducible property
AradhyaTiwari10 Oct 28, 2025
9068fa3
chore: remove generated bom.json from repo
AradhyaTiwari10 Oct 28, 2025
6d4c600
fix: use PropertyNames.BomReproducible for reproducible property in m…
AradhyaTiwari10 Oct 28, 2025
6e00988
feat: add cdx:reproducible property inside metadata region
AradhyaTiwari10 Oct 28, 2025
ffe3f02
fix: move BomReproducible property into metadata region and reuse rep…
AradhyaTiwari10 Oct 28, 2025
5a0fc9d
fix: reorder reproducible condition and follow coding guidelines
AradhyaTiwari10 Oct 28, 2025
462dddd
feat: set devDependencies component.scope to excluded
AradhyaTiwari10 Oct 29, 2025
a0b2dd5
Merge branch 'CycloneDX:main' into feat/excluded-scope-devdeps
AradhyaTiwari10 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/builders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,15 @@ export class BomBuilder {
} else {
bom.serialNumber = Utils.BomUtility.randomSerialNumber()
bom.metadata.timestamp = new Date()
bom.metadata.properties.add(
Copy link
Member

@jkowalleck jkowalleck Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an unintended change.
Please revert

new Models.Property(
PropertyNames.BomReproducible,
PropertyValueBool.False
)
)
}
// endregion metadata

// endregion metadata
Copy link
Member

@jkowalleck jkowalleck Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an unintended change.
Please revert

// region components
if (this.flattenComponents) {
for (const c of allComponents.values()) {
Expand Down Expand Up @@ -479,11 +485,14 @@ export class BomBuilder {
})
}

if (isExcluded) {
component.scope = Enums.ComponentScope.Excluded
} else if (isOptional) {
component.scope = Enums.ComponentScope.Optional
}
if (isExcluded) {
component.scope = Enums.ComponentScope.Excluded
} else if (isOptional) {
component.scope = Enums.ComponentScope.Optional
} else if (data.dev === true || data.devOptional === true) {
Copy link
Member

@jkowalleck jkowalleck Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets have a const for the term data.dev === true || data.devOptional === true - list like isOptional.
Could you add this const and use it where possible?

component.scope = Enums.ComponentScope.Excluded
}


// region properties
if (data.dev === true || data.devOptional === true) {
Expand Down