singularity-finance: use new vault registry and batch calls #2138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As you can see the test fails here but it runs for us locally, however not all of the time. The issue is 429 rate limit or unsynced nodes. |
|
@a-k-l-sdao ran this locally, this looks v wrong: (see tvlUsd) |
… multicall and get info in batch calls of 100, get tvlUsd using oracle(via vault)
|
The singularity-finance adapter exports pools: Test Suites: 1 passed, 1 total |
|
Thank you for bringing this observation to our attention. |
|
The singularity-finance adapter exports pools: Test Suites: 1 passed, 1 total |
|
@a-k-l-sdao keep in mind, that on defillama we list pools as long as they fulfil the min tvl criteria of $10k some of the vaults have negative apr? and seems like this link (maybe others too) doesn't work https://singularityfinance.ai/vaults/0xd8d294714F5b1A1104CFE75C0Bb4ceF547a05124 |
Thank you for your comment.
On a side note: the majority of the current vaults are test vaults with 0 tvl that will be disabled and not included. |
…o and refactor script to only pull beta and prod vaults
|
The singularity-finance adapter exports pools: Test Suites: 1 passed, 1 total |
I have pushed an update to the script. I added a multicall version of the utils.getERC4626Info in our script (feel free to add it in utils) and filter by onchain vault types. all links should work now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing, we ran into some issues with Jest showing AggregateError messages caused by rate limiting. To make the script more robust, we updated our vault registry to support fetching vaults in batches.
We’re also preparing to launch a new product that lets users deploy their own vaults, which will significantly increase the total number of vaults (already at 175 and growing). This change ensures the system can handle the higher volume smoothly.