Skip to content

Conversation

smith-kyle
Copy link
Member

No description provided.

Copy link

gitnotebooks bot commented Oct 25, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/GitNotebooks/demo/pull/3

@gitnotebooks-staging
Copy link

Found 1 changed notebook. Review the changes at https://app-staging.gitnotebooks.com/GitNotebooks/demo/pull/3

Copy link

@paulmlv-upstart paulmlv-upstart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, a few questions.

@@ -0,0 +1,314 @@
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 1 Line 1

# Introducing Scikit-Learn

Optional: Add API link.

@@ -0,0 +1,314 @@
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 10 Line 4

plt.scatter(data_projected[:, 0], data_projected[:, 1], c=digits.target,
            edgecolor='none', alpha=0.5,
            cmap=plt.cm.get_cmap('spectral', 10))
plt.colorbar(label='digit label', ticks=range(10))

Why range(10)?

@@ -0,0 +1,314 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 3 Line 5

import seaborn as sns
from utils import summarize_dataframe

iris = sns.load_dataset('iris')

test

@@ -0,0 +1,314 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 5 Line 2

iris['PCA1'] = X_2D[:, 0]
iris['PCA2'] = X_2D[:, 1]

test

@@ -0,0 +1,314 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 7 Line 1

### Unsupervised learning: Dimensionality reduction

test

@@ -0,0 +1,314 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 8 Line 2

from sklearn.manifold import Isomap
iso = Isomap(n_components=2)

test

@@ -0,0 +1,314 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 8 From line 2 to 4

iso = Isomap(n_components=2)
iso.fit(digits.data)
data_projected = iso.transform(digits.data)

test

@@ -0,0 +1,314 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 3 Line 1

import seaborn as sns

test

@@ -0,0 +1,314 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 3 Line 2

import seaborn as sns
from utils import summarize_dataframe

test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants