Skip to content

Conversation

@tsmbland
Copy link
Collaborator

@tsmbland tsmbland commented Nov 5, 2024

Description

Please include a summary of the change and which issue is fixed (if any). Please also
include relevant motivation and context. List any dependencies that are required for
this change.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass: $ python -m pytest
  • The documentation builds and looks OK: $ python -m sphinx -b html docs docs/build

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@tsmbland tsmbland changed the base branch from main to refactor November 5, 2024 16:12
Base automatically changed from refactor to v1.3 November 5, 2024 16:59
@tsmbland
Copy link
Collaborator Author

Replaced by #572 (this PR has got messy as I rebased it from main)

@tsmbland tsmbland closed this Nov 20, 2024
@tsmbland tsmbland deleted the trade_model branch December 3, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants