Skip to content

Commit d77a4d9

Browse files
committed
Cleanup some comments
1 parent 53112ca commit d77a4d9

File tree

2 files changed

+1
-24
lines changed

2 files changed

+1
-24
lines changed

ext/ReactantMPIExt/Ops.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,8 +287,6 @@ function send(
287287
sym_name = "enzymexla_wrapper_MPI_Send_$(mpi_datatype_name)"
288288
sym_attr = IR.FlatSymbolRefAttribute(sym_name)
289289

290-
# TODO emit constant for size and datatype, and pass as args
291-
292290
IR.inject!("MPI_COMM_WORLD", "llvm.mlir.global constant @MPI_COMM_WORLD() : !llvm.ptr")
293291
IR.inject!(
294292
"MPI_Send",

ext/ReactantMPIExt/Overrides.jl

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -71,34 +71,13 @@ function MPI.Isend(
7171
return Ops.isend(buf, tag, dest)
7272
end
7373

74-
# TODO possible to use this signature? As is, ambiguous with the ones defined by MPI.jl
75-
# # TODO use `make_tracer` to linearize arbitrary types? check out `MPI.Buffer`
76-
# function MPI.Isend(
77-
# buf::TracedRArray,
78-
# dest::Union{T,TracedRNumber{T}},
79-
# tag::Union{T,TracedRNumber{T}},
80-
# comm::MPI.Comm,
81-
# ) where {T<:Integer}
82-
# @assert comm == MPI.COMM_WORLD "Only MPI.COMM_WORLD is supported currently"
83-
84-
# tag = if !(tag isa TracedRNumber)
85-
# Reactant.Ops.constant(tag)
86-
# end
87-
88-
# dest = if !(dest isa TracedRNumber)
89-
# Reactant.Ops.constant(dest)
90-
# end
91-
92-
# return Ops.isend(buf, tag, dest)
93-
# end
94-
9574
function MPI.Recv!(buf::TracedRArray, source::Integer, tag::Integer, comm::MPI.Comm)
9675
tag = Reactant.Ops.constant(tag)
9776
source = Reactant.Ops.constant(source)
9877
return MPI.Recv!(buf, source, tag, comm)
9978
end
10079

101-
# TODO Do we need these? Comment out at least until everything is working
80+
# TODO Do we need these?
10281
# function MPI.Recv!(
10382
# buf::TracedRArray,
10483
# source::Integer,

0 commit comments

Comments
 (0)