Skip to content

try restore softmax tpu #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

try restore softmax tpu #1592

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75bbdd6
try restore softmax tpu
wsmoses Aug 27, 2025
319f935
Set DUMP_MLIR_ALWAYS to true
wsmoses Aug 27, 2025
430c2c2
Merge branch 'main' into wsmoses-patch-5
wsmoses Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ext/ReactantNNlibExt/Implementations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,19 @@ for (jlop, hloop) in (
@eval $(jlop)(x::TracedRNumber) = @opcall $(hloop)(x)
end

Reactant.MLIR.IR.DUMP_MLIR_ALWAYS[] = true

function NNlib.softmax!(out::AnyTracedRArray{T,N}, x::AbstractArray; dims=1) where {T,N}
x = T.(Reactant.materialize_traced_array(x))
max_ = maximum(x; dims)
diff = exp.(x .- max_)
# TOOD: re-enable conditional once https://github.com/EnzymeAD/Reactant.jl/issues/1581
# fixed
# @trace if all(isfinite, max_)
@. out = diff
# else
# @. out = ifelse(isinf(max_), ifelse(isinf(x), T(1), T(0)), diff)
# end
@trace if all(isfinite, max_)
@. out = diff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
@. out = diff
@. out = diff

else
@. out = ifelse(isinf(max_), ifelse(isinf(x), T(1), T(0)), diff)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
@. out = ifelse(isinf(max_), ifelse(isinf(x), T(1), T(0)), diff)
@. out = ifelse(isinf(max_), ifelse(isinf(x), T(1), T(0)), diff)

end
out ./= sum(out; dims)
return out
end
Expand Down
Loading