Skip to content

handle error #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

handle error #227

wants to merge 2 commits into from

Conversation

amanshawar
Copy link
Collaborator

fix #183

jema28
jema28 suggested changes Apr 16, 2019
View reviewed changes
client/src/components/Shared/Error/error.style.js Outdated
import styled from 'styled-components';

export default styled.h1`
font-size: 20px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation.

client/src/components/SignUp/index.js Outdated
confirmPassword: this.state.confirmPassword,
};
axios.post('/signup', inputs).then(({ data }) => {
axios.post('/signup', 'inputs').then(({ data }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be in quotes?

@jema28
Copy link
Contributor

jema28 commented Apr 16, 2019

Can you explain what you're doing here? Why do all things default to server error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jema28 jema28 jema28 requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error handling in BE
2 participants
@amanshawar @jema28