Added Gearplace subsystem, works with FRamework #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiloDavis
suggested changes
Feb 22, 2017
|
|
||
| @Override | ||
| public void registerSubscriptions() { | ||
| openButton.map(x -> x ? ServoInstr.set(0.0) : ServoInstr.set(0.5)) |
There was a problem hiding this comment.
Aren't these going to the limits? Shouldn't these be 1.0 and 0.0?
| public static final int FRONT_RIGHT = 14; | ||
| public static final int BACK_RIGHT = 15; | ||
|
|
||
| // Ports of Servos TODO: Fix Port to match robot servos |
There was a problem hiding this comment.
Ask about ports and fill in ASAP
ashergottlieb
force-pushed
the
Gear-Placer
branch
from
e96e84d to
117ec1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Merging
Check the following subsystems work:
Drivetrain
Turn to angleShooter
Turret/Vision
Turns to target w/ visionClimbtake
Auto