Support getPageSource endpoint #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristotelos
requested changes
Jun 6, 2025
There was a problem hiding this comment.
Looks great in general. Two things are missing though:
- UI tests that prove that this works (https://github.com/FlaUI/FlaUI.WebDriver/tree/main/src/FlaUI.WebDriver.UITests)
- Update of the README explaining the feature (because "page source" is interpreted in a certain way here). If we follow a convention set by WinAppDriver, refer to it as well
|
The build check is failing because a step in the pipeline was deprecated. Rebase to pull in the fix for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support getPageSource endpoint to fill the gap with WinAppDriver