Skip to content

Conversation

Jack251970
Copy link
Member

Related Flow-Launcher/Flow.Launcher#3593. Wait for next Flow release to merge

Copy link
Contributor

coderabbitai bot commented Sep 27, 2025

📝 Walkthrough

Walkthrough

Updated the XAML namespace URI for the "m" prefix in src/components/theme-builder/state/AllState.svelte.ts from http://schemas.modernwpf.com/2019 to http://schemas.inkore.net/lib/ui/wpf/modern. No other logic or public API changes.

Changes

Cohort / File(s) Summary of Changes
Namespace URI update
src/components/theme-builder/state/AllState.svelte.ts
Changed XAML namespace for prefix "m" from http://schemas.modernwpf.com/2019 to http://schemas.inkore.net/lib/ui/wpf/modern; no other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

enhancement

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly highlights the main change of updating the namespace for the iNKORE.UI.WPF.Modern nuget package, matching the code modifications in AllState.svelte.ts. It is concise and specific, avoiding unnecessary details, so readers can quickly grasp the primary update. No other aspects of the changeset are omitted or misrepresented.
Description Check ✅ Passed The pull request description references the related Flow.Launcher pull request and clarifies the dependency on the next Flow release, which directly relates to the namespace update. It provides context for when the change should be merged without detailing implementation specifics. This keeps the description on-topic and relevant to the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ui_wpf_modern

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c93f26d and d6efcdf.

📒 Files selected for processing (1)
  • src/components/theme-builder/state/AllState.svelte.ts (1 hunks)
🔇 Additional comments (1)
src/components/theme-builder/state/AllState.svelte.ts (1)

60-63: Namespace update aligns with iNKORE UI Modern

The new xmlns:m URI matches the iNKORE.UI.WPF.Modern package, so the emitted XAML should keep resolving the controls correctly. Looks good.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jjw24
Copy link
Member

jjw24 commented Oct 4, 2025

If we merge this in now, is it going to break themes created for users still on production version?

@Jack251970
Copy link
Member Author

If we merge this in now, is it going to break themes created for users still on production version?

yes, so please wait for next release to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants