Update for Flux 0.10 #42
Conversation
| return env._env.state | ||
| end | ||
| end | ||
| return _get_obs(env._env) |
There was a problem hiding this comment.
Any reason to get rid of the catch?
There was a problem hiding this comment.
I don't recall exactly what the error message was that caused me to remove it. Maybe Zygote can't differentiate through it?
There was a problem hiding this comment.
Ah yes we don't support try blocks in zygote yet.
But this would seem to break Gym's assumptions about what to do in case of an error here. I'm happy to have a wrapper method that would dispatch accordingly to get rid of try block
There was a problem hiding this comment.
We could have a _get_obs which by default returns env._env.state
There was a problem hiding this comment.
Can we have that dispatched correctly and have this merged then?
There was a problem hiding this comment.
I don't understand enough about this to implement "correct dispatch", but I think you can edit the pull request.
|
|
||
| trainable(env::EnvWrapper) = env.train | ||
| game_over(env::EnvWrapper) = env.done | ||
| game_over(env::EnvWrapper) = env.done |
There was a problem hiding this comment.
Oh, funny. I didn't realize I had touched that line. I had used the web editor. If this is a problem, I think you have permission to fix this inline.
|
cc @tejank10 |
I've been trying to get the Gym working for the control problems in the model zoo.
These fixes to Gym (together with fixes in the model zoo) allowed me to get this working with the latest version of Flux