-
Notifications
You must be signed in to change notification settings - Fork 0
Default to SQLite (over PostgreSQL) #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,4 @@ __pycache__ | |
.coverage* | ||
coverage.xml | ||
htmlcov | ||
freemusicninja.sqlite |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
psycopg2==2.5.4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I would prefer to add a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Requirements can only be specified once, even if they don't conflict. If I add the general requirements here, it will prevent this requirement file from being combined in the same install command as What we could do is have a folder with the different types of requirements, and these top-level files would just combine them. Edit: What I meant is specific package requirements can only be specified once, you can use multiple requirement files in the same installation command as I've done in both the CI and deploy configuration. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we need to support prod-requirements.txt and dev-requirements.txt in the same command. The convention of importing a base requirements file seems to be very common. It's the way Two Scoops does it: https://github.com/twoscoops/django-twoscoops-project/blob/develop/requirements/production.txt I haven't seen the convention of splitting requirements and installing multiple requirements at once. It's possible I overlooked it somewhere though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we list these postgres requirements somewhere for deployment documentation/information? Just a thought.