adds in the forgotten unique key email alias #447
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhdruk
reviewed
Jun 11, 2024
| $to = [ | ||
| 'to' => [ | ||
| 'email' => $arr['user']['email'], | ||
| 'email' => str_replace('@', '+' . $threadDetail['thread']['unique_key']. '@', $arr['user']['email']), |
There was a problem hiding this comment.
I think the value for email is same like $aliasEmail
dnhdruk
reviewed
Jun 11, 2024
Comment on lines
+290
to
+293
| return response()->json([ | ||
| 'message' => Config::get('statuscodes.STATUS_BAD_REQUEST.message'), | ||
| 'data' => null, | ||
| ], Config::get('statuscodes.STATUS_BAD_REQUEST.code')); |
There was a problem hiding this comment.
I think it is a try { ... } catch (..) { ... } and this part will not be reach
dnhdruk
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots (if relevant)
Describe your changes
Issue ticket link
Environment / Configuration changes (if applicable)
Requires migrations being run?
If not using the pre-push hook. Confirm tests pass:
Checklist before requesting a review