Rotate Kernel #44
Closed
Rotate Kernel #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix enables generate_p_isa_ops_pgm and run_p_isa to scripts in functional modeler to run properly and keeps the naming convention consistant between hec-p-isa-tools and HERACLES-SEAL-isa-mapping.
… problem with relin, which rotate uses partially Signed-off-by: christopherngutierrez <[email protected]>
…stopherngutierrez/relin
…r reconsidered in the future
…o christopherngutierrez/rotate
…tilize common polys for relin/rotate.
christopherngutierrez
requested review from
faberga,
kylanerace,
jobottle,
hamishun and
jlhcrawford
as code owners
kylanerace
previously approved these changes
Sep 16, 2024
faberga
reviewed
Sep 17, 2024
|
This PR is dependent on PR #43 and should not be merged before it. |
faberga
requested changes
Sep 18, 2024
kerngen/pisa_generators/relin.py
Outdated
| add_original.name = self.input0.name | ||
|
|
||
| return mixed_to_pisa_ops( | ||
| opts = mixed_to_pisa_ops( |
There was a problem hiding this comment.
This was resolved in the Relin PR but resurface in the Rotate. Sounds as the rotate code has not been rebased correctly.
kerngen/pisa_generators/relin.py
Outdated
| Add(self.context, self.output, mul_by_rlk_modded_down, add_original), | ||
| Comment("End of relin kernel"), | ||
| ) | ||
| return opts |
…isa_ops directly.
|
Closed as this PR has been superseded by PR #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added rotate kernel, which has been tested and validated to work.
Minor changes (to avoid code replication):
Types of changes
What types of changes does your code introduce to the HE Toolkit project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.