Skip to content

Conversation

christopherngutierrez
Copy link
Contributor

@christopherngutierrez christopherngutierrez commented Sep 18, 2024

Proposed changes

Enhancements to the NTT/INTT kernel to support support generic power of 2 polynomials - Tested for 16k, 32k, 64k, and 128k.

Types of changes

What types of changes does your code introduce to the HE Toolkit project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

This feature has been tested against an experimental version of the functional modeler and passes the functional tests that validate the correctness of the computation for power of 2 polynomials.

@faberga faberga changed the title Bug fix for ntt/intt to support 16k, 32k, and 64k Bug fix for ntt/intt to support support generic power of 2 polynomials - Tested for 16k, 32k, 64k, and128k. Sep 18, 2024
@faberga faberga changed the title Bug fix for ntt/intt to support support generic power of 2 polynomials - Tested for 16k, 32k, 64k, and128k. Enhancements to the NTT/INTT kernel to support support generic power of 2 polynomials - Tested for 16k, 32k, 64k, and128k. Sep 18, 2024
@faberga faberga changed the title Enhancements to the NTT/INTT kernel to support support generic power of 2 polynomials - Tested for 16k, 32k, 64k, and128k. Enhancements to the NTT/INTT kernel to support support generic power of 2 polynomials - Tested for 16k, 32k, 64k, and 128k. Sep 18, 2024
Copy link
Contributor

@jobottle jobottle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@faberga faberga merged commit cec8bb9 into main Sep 18, 2024
3 checks passed
@faberga faberga deleted the christopherngutierrez/ntt branch September 18, 2024 19:03
@faberga faberga added the enhancement New feature or request label Sep 18, 2024
christopherngutierrez added a commit that referenced this pull request Oct 21, 2024
…of 2 polynomials - Tested for 16k, 32k, 64k, and 128k. (#46)

Enhancements to the NTT/INTT kernel to support support generic power of 2 polynomials - Tested for 16k, 32k, 64k, and 128k.

Co-authored-by: Flavio Bergamaschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants