Move common functionality to basic.py and DigitDecompExtend to decomp.py #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherngutierrez
requested review from
faberga,
kylanerace,
jobottle,
hamishun and
jlhcrawford
as code owners
faberga
reviewed
Sep 20, 2024
Modified comment Co-authored-by: Flavio Bergamaschi <[email protected]>
faberga
approved these changes
Sep 20, 2024
faberga
deleted the
christopherngutierrez/common-functionality-refactor
branch
christopherngutierrez
added a commit
that referenced
this pull request
Oct 21, 2024
….py (#47) * Refactor KeyMul and move it to basic.py * Refactor and move DigitDecompExtend to its own file, decomp.py. --------- Co-authored-by: Flavio Bergamaschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
PR to move KeyMul from relin.py to basic.py. Adds a helper function to basic.py which is used in Relin (and will be used in a future PR for Rotate). The PR also moves DigitDecompExtend to its own file, decomp.py. Further, a minor change to KeyMul & Relin to control Mul/Mac a specific part on the input. Confirmed to pass test on Relin on with 16k poly mods.
Types of changes
What types of changes does your code introduce to the HE Toolkit project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
The PR is mainly used to organize common components and avoid code replication.