Skip to content

Conversation

christopherngutierrez
Copy link
Contributor

Proposed changes

  • Fixes incorrect output when total number of butterfly stages is odd
  • Tested on NTT/INTT/Relin kernels of poly orders 16k, 32k, 64k, and 128k.

Types of changes

What types of changes does your code introduce to the HE Toolkit project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@christopherngutierrez christopherngutierrez changed the title Fix NTT issue on Odd numbered butterfly stages Fix NTT issue on odd-numbered butterfly stages Sep 25, 2024
@faberga faberga added the bug Something isn't working label Sep 26, 2024
Copy link
Contributor

@jobottle jobottle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@faberga faberga merged commit 7160e5a into main Sep 26, 2024
3 checks passed
@faberga faberga deleted the christopherngutierrez/ntt-bug-fix branch September 26, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants