Skip to content

Bug fix for NTT Kernel #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Bug fix for NTT Kernel #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions kerngen/pisa_generators/ntt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,21 +90,20 @@ def to_pisa(self) -> list[PIsaOp]:
# TODO We need to decide whether output symbols need to be defined
outtmp = Polys("outtmp", self.output.parts, self.output.rns)

# control the input for the butterfly method.
# Essentially a scalar mul since psi 1 part
if self.context.ntt_stages % 2 == 0:
# Essentially a scalar mul since psi 1 part
# Even case: butterfly input starts "coeff"
mul = Mul(self.context, self.output, self.input0, psi)
butterfly_input = outtmp
else:
# Odd case: butterfly input stats with "outtmp"
mul = Mul(self.context, outtmp, self.input0, psi)
butterfly_input = self.input0

butterflies = butterflies_ops(
pisa_op.NTT,
context=self.context,
output=self.output,
outtmp=outtmp,
input0=butterfly_input,
input0=self.input0,
)

return mixed_to_pisa_ops(mul, butterflies)
Expand Down