New Kernel Generators for CKKS #53

christopherngutierrez · 2024-10-07T22:23:25Z

Proposed changes

Provides Rescale Kernel generator for CKKS
Tested for 16K, 32K, 64K and 128K poly order

Types of changes

What types of changes does your code introduce to the HE Toolkit project?
Put an x in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

I have read the CONTRIBUTING agreement
Current formatting and unit tests / base functionality passes locally with my changes
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added necessary documentation (if appropriate)
Any dependent changes have been merged and published in downstream modules

Further comments

…ix enables generate_p_isa_ops_pgm and run_p_isa to scripts in functional modeler to run properly and keeps the naming convention consistant between hec-p-isa-tools and HERACLES-SEAL-isa-mapping.

…y order.

…ix enables generate_p_isa_ops_pgm and run_p_isa to scripts in functional modeler to run properly and keeps the naming convention consistant between hec-p-isa-tools and HERACLES-SEAL-isa-mapping.

…y order.

kerngen/pisa_generators/rescale.py

faberga

Please convert code blocks annotated in comments to functions for clarity.
Also add comments to each stage.
Thanks

…hec-p-isa-tools into christopherngutierrez/rescale

kerngen/pisa_generators/rescale.py

faberga

See comments above.

…r functions to basic which are used by mod/rescale kerns.

* Experimental VS Code Extension for the Kernel Language * Kernel Language examples Signed-off-by: Flavio Bergamaschi <[email protected]>

…#41)

This PR implements the an experimental fix for a few issues in the RELIN kernel. Namely, the RELIN kernel generated code that was segmented due issues with composing DigitalDecompExtend and Keymul together. This fix uses internal temporary variables output_tmp , which will be refactored out in a following PR. Further, the input polynomials parts are hardcoded to 3 and output parts to 2 since the code assumes those sizes (also to be refactored to be more generic in the future). Today the RELIN kernel only supports 16k polynomials due to a limitation of the NTT/INTT kernels. This limitation is being removed and the RELIN kernel will be updated accordingly.

…of 2 polynomials - Tested for 16k, 32k, 64k, and 128k. (#46) Enhancements to the NTT/INTT kernel to support support generic power of 2 polynomials - Tested for 16k, 32k, 64k, and 128k. Co-authored-by: Flavio Bergamaschi <[email protected]>

….py (#47) * Refactor KeyMul and move it to basic.py * Refactor and move DigitDecompExtend to its own file, decomp.py. --------- Co-authored-by: Flavio Bergamaschi <[email protected]>

Fixes a bug that caused odd number of total NTT stages to write to incorrect output.

* Added a check in types and a test function in test_kerngen to verify that the poly order is a power of two and within upper(2**17)/lower(2**14) bounds. Co-authored-by: Flavio Bergamaschi <[email protected]>

* Adds Rotate Kernel for BGV. Tested for 16k, 32k, 64k and 128k Poly mod. * rotate.py - implementation of rotate kernel * manifest.json - adds rotate entry to BGV manifest --------- Co-authored-by: Flavio Bergamaschi <[email protected]>

Updates the requirements on [pylint](https://github.com/pylint-dev/pylint) to permit the latest version. - [Release notes](https://github.com/pylint-dev/pylint/releases) - [Commits](pylint-dev/pylint@v3.2.0...v3.3.0) --- updated-dependencies: - dependency-name: pylint dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Flavio Bergamaschi <[email protected]>

…ix enables generate_p_isa_ops_pgm and run_p_isa to scripts in functional modeler to run properly and keeps the naming convention consistant between hec-p-isa-tools and HERACLES-SEAL-isa-mapping.

…y order.

Bug fix for NTT Kernel generating extra unnecessary P-ISA instructions.

…r functions to basic which are used by mod/rescale kerns.

Updates the requirements on [black](https://github.com/psf/black) to permit the latest version. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@24.8.0...24.10.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…hec-p-isa-tools into christopherngutierrez/rescale

faberga · 2024-10-23T16:48:51Z

Closed - Superseded by PR #55

christopherngutierrez added 13 commits July 24, 2024 14:25

Modified default manifest to use MOD_SWITCH key instead of MOD. The f…

32e984d

…ix enables generate_p_isa_ops_pgm and run_p_isa to scripts in functional modeler to run properly and keeps the naming convention consistant between hec-p-isa-tools and HERACLES-SEAL-isa-mapping.

Added core functionality for rescale ckks. Currently not tested

16c58b5

Modified default manifest to use MOD_SWITCH key instead of MOD. The f…

28f5c04

…ix enables generate_p_isa_ops_pgm and run_p_isa to scripts in functional modeler to run properly and keeps the naming convention consistant between hec-p-isa-tools and HERACLES-SEAL-isa-mapping.

Added core functionality for rescale ckks. Currently not tested

954ee29

modified manifest to include rescale

218cf3f

merged manifest

2b1cc97

initial working version of rescale. Confirmed working for 16-128K pol…

2e51ccc

…y order.

Added core functionality for rescale ckks. Currently not tested

fcaa364

modified manifest to include rescale

214d4de

Modified default manifest to use MOD_SWITCH key instead of MOD. The f…

f7b169b

…ix enables generate_p_isa_ops_pgm and run_p_isa to scripts in functional modeler to run properly and keeps the naming convention consistant between hec-p-isa-tools and HERACLES-SEAL-isa-mapping.

Added core functionality for rescale ckks. Currently not tested

a410065

initial working version of rescale. Confirmed working for 16-128K pol…

a4b1dcd

…y order.

merged manifest

9b77cee

christopherngutierrez requested review from faberga, hamishun, jlhcrawford, jobottle and kylanerace as code owners October 7, 2024 22:23

faberga added the enhancement New feature or request label Oct 8, 2024

faberga changed the title ~~CKKS Rescale~~ CKKS Rescale Feature Oct 8, 2024

Merge branch 'main' into christopherngutierrez/rescale

46ea5d0

faberga changed the title ~~CKKS Rescale Feature~~ New Kernel Generators for CKKS Oct 8, 2024

faberga reviewed Oct 8, 2024

View reviewed changes

kerngen/pisa_generators/rescale.py Outdated Show resolved Hide resolved

faberga reviewed Oct 8, 2024

View reviewed changes

kerngen/pisa_generators/rescale.py Outdated Show resolved Hide resolved

faberga requested changes Oct 8, 2024

View reviewed changes

christopherngutierrez added 2 commits October 9, 2024 12:33

Added 'partial ops' helper funcitons

a0b2fa6

Merge branch 'christopherngutierrez/rescale' of github.com:IntelLabs/…

32d60fa

…hec-p-isa-tools into christopherngutierrez/rescale

faberga reviewed Oct 9, 2024

View reviewed changes

kerngen/pisa_generators/rescale.py Show resolved Hide resolved

faberga requested changes Oct 9, 2024

View reviewed changes

Removed some duplicated code between mod and rescale. Added two helpe…

5944619

…r functions to basic which are used by mod/rescale kerns.

faberga and others added 26 commits October 21, 2024 16:15

Update kerngen README.md (#39)

937c548

Kernel Language examples + Experimental VS Code Extension (#40)

e803922

* Experimental VS Code Extension for the Kernel Language * Kernel Language examples Signed-off-by: Flavio Bergamaschi <[email protected]>

Bug fix in the RELIN kernel generator to use the correct named input0 (…

f6a6f11

…#41)

Update CODEOWNERS (#42)

93c5575

Move common functionality to basic.py and DigitDecompExtend to decomp…

b85e1d4

….py (#47) * Refactor KeyMul and move it to basic.py * Refactor and move DigitDecompExtend to its own file, decomp.py. --------- Co-authored-by: Flavio Bergamaschi <[email protected]>

Fix NTT issue on odd-numbered butterfly stages

678b41b

Fixes a bug that caused odd number of total NTT stages to write to incorrect output.

Tests for invalid poly order

c90ce59

* Added a check in types and a test function in test_kerngen to verify that the poly order is a power of two and within upper(2**17)/lower(2**14) bounds. Co-authored-by: Flavio Bergamaschi <[email protected]>

BGV Rotate Kernel (#48)

f23802d

* Adds Rotate Kernel for BGV. Tested for 16k, 32k, 64k and 128k Poly mod. * rotate.py - implementation of rotate kernel * manifest.json - adds rotate entry to BGV manifest --------- Co-authored-by: Flavio Bergamaschi <[email protected]>

Added core functionality for rescale ckks. Currently not tested

558db6a

modified manifest to include rescale

eea3924

Modified default manifest to use MOD_SWITCH key instead of MOD. The f…

cd4a73e

…ix enables generate_p_isa_ops_pgm and run_p_isa to scripts in functional modeler to run properly and keeps the naming convention consistant between hec-p-isa-tools and HERACLES-SEAL-isa-mapping.

Added core functionality for rescale ckks. Currently not tested

bf1d082

initial working version of rescale. Confirmed working for 16-128K pol…

12a9084

…y order.

Added core functionality for rescale ckks. Currently not tested

5399ddc

initial working version of rescale. Confirmed working for 16-128K pol…

7ad2fd6

…y order.

Added 'partial ops' helper funcitons

0a99abf

Bug fix for NTT Kernel generating extra unnecessary P-ISA instructions.

8dee2fa

Bug fix for NTT Kernel generating extra unnecessary P-ISA instructions.

Removed some duplicated code between mod and rescale. Added two helpe…

21c8eae

…r functions to basic which are used by mod/rescale kerns.

Created a new helper method to generate commonly used immediates

62b3fcc

moved partial_op to sep file and refactored code

a7fe038

fixed a typo after merging

ef1b48a

Merge branch 'christopherngutierrez/rescale' of github.com:IntelLabs/…

8c78c6a

…hec-p-isa-tools into christopherngutierrez/rescale

christopherngutierrez mentioned this pull request Oct 22, 2024

New Kernel Generators for CKKS (Updated) #55

Merged

9 tasks

faberga closed this Oct 23, 2024

faberga deleted the christopherngutierrez/rescale branch October 23, 2024 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

New Kernel Generators for CKKS #53

New Kernel Generators for CKKS #53

Uh oh!

christopherngutierrez commented Oct 7, 2024 •

edited by faberga

Loading

Uh oh!

Uh oh!

Uh oh!

faberga left a comment

Uh oh!

Uh oh!

faberga left a comment

Uh oh!

faberga commented Oct 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

New Kernel Generators for CKKS #53

New Kernel Generators for CKKS #53

Uh oh!

Conversation

christopherngutierrez commented Oct 7, 2024 • edited by faberga Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Types of changes

Checklist

Further comments

Uh oh!

Uh oh!

Uh oh!

faberga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

faberga left a comment

Choose a reason for hiding this comment

Uh oh!

faberga commented Oct 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

christopherngutierrez commented Oct 7, 2024 •

edited by faberga

Loading