Skip to content

Conversation

faberga
Copy link
Collaborator

@faberga faberga commented May 22, 2025

Proposed changes

This is a Reference implementation of the Assembler tools for the HERACLES platform

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • [N/A] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • [N/A] Any dependent changes have been merged and published in downstream modules

Further comments

This PR brings into the Encrypted Computing SDK a reference implementation of the Assembler tools for the HERACLES platform.

@faberga faberga added documentation Improvements or additions to documentation enhancement New feature or request labels May 22, 2025
@faberga faberga self-assigned this May 22, 2025
Delete this CODEOWNERS file as it is not required in a sub-directory
faberga added 2 commits May 23, 2025 19:44
Update README.md to be inline with latest codebase
Update README.md with correct reference to the PGM
faberga added 2 commits May 23, 2025 20:18
kylanerace
kylanerace previously approved these changes May 23, 2025
Copy link
Collaborator

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remove old style execution instructions
kylanerace
kylanerace previously approved these changes May 23, 2025
Copy link
Collaborator

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@faberga faberga requested a review from kylanerace May 23, 2025 20:52
Copy link
Collaborator

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@christopherngutierrez christopherngutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. All changes have been addressed and tested python scripts locally.

@faberga faberga merged commit 1090185 into main May 23, 2025
8 checks passed
@faberga faberga deleted the flavio/assembler-tools branch May 23, 2025 21:12
christopherngutierrez pushed a commit that referenced this pull request Jun 10, 2025
* Reference implementation of the HERACLES Assembler tools
---------

Signed-off-by: Flavio Bergamaschi <[email protected]>

Co-authored-by: Flavio Bergamaschi <[email protected]>
Co-authored-by: Ernesto Zamora Ramos <[email protected]>
Co-authored-by: Chris Wilkerson <[email protected]>
Co-authored-by: Jose Rojas Chaves <[email protected]>
Co-authored-by: Kylan Race <[email protected]>
Co-authored-by: Christopher Gutierrez <[email protected]>
Co-authored-by: Hamish Hunt <[email protected]>
Co-authored-by: Jack Crawford <[email protected]>
Co-authored-by: Minxuan Zhou <[email protected]>
Co-authored-by: Wen Wang <[email protected]>
Co-authored-by: Adish Vartak <[email protected]>
Co-authored-by: Michael Steiner <[email protected]>
Co-authored-by: Avinash Alevoor <[email protected]>
Co-authored-by: Rashmi Agrawal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants