Skip to content

Conversation

joserochh
Copy link
Contributor

@joserochh joserochh commented May 26, 2025

Proposed changes

Fix suggested bank error by adding dependencies to eviction XStore instructions. This avoids instructions coming before a variable is allocated in correct bank.

Types of changes

What types of changes does your code introduce to the Encrypted Computing SDK project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@joserochh joserochh added bug Something isn't working python Pull requests that update python code labels May 27, 2025
@joserochh joserochh marked this pull request as ready for review June 4, 2025 15:51
@joserochh joserochh changed the title Fix suggested bank error [hec-assembler]: Fix suggested bank error Jun 4, 2025
@kylanerace
Copy link
Collaborator

Actively testing this for outliers currently

@faberga
Copy link
Collaborator

faberga commented Jun 5, 2025

Hi @joserochh , is this ready for revision?

Copy link
Collaborator

@faberga faberga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out and not seeing any regressions in functionality/performance beyond some execution time. LGTM

@faberga
Copy link
Collaborator

faberga commented Jun 10, 2025

@joserochh I guess this is good to merge. It would be good to do so before Christopher rebases his branch, to avoid having to rebase this one again.

@joserochh joserochh merged commit e84776b into main Jun 10, 2025
7 of 8 checks passed
@joserochh joserochh deleted the joserochh/suggested_bank_fix branch June 10, 2025 19:42
christopherngutierrez pushed a commit that referenced this pull request Jun 10, 2025
Fixes suggested bank error

Co-authored-by: Kylan Race <[email protected]>
Co-authored-by: Flavio Bergamaschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants