-
Notifications
You must be signed in to change notification settings - Fork 4
[hec-assembler]: Enable Configurable Memory Specification #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @joserochh , this PR is still in |
Hello @faberga, I have added documentation and compared the output of this branch against a vanilla branch for a variety of Kernels. So, I will move this to ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed and reviewed, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Enabling configurable mem specifications * Adding documentation
Proposed changes
Enable mem parameter configuration in the same manner as ISA Spec parameters are configurable. Providing a configuration (.json) file is required. A default file has been added under config folder and command line flags have been added to overwrite path to a different file if necessary.
Types of changes
What types of changes does your code introduce to the Encrypted Computing SDK project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.