Skip to content

Conversation

christopherngutierrez
Copy link
Contributor

Proposed changes

PR fixes pre-commit.yaml and pytest.ini config files to match new directory structure.

Types of changes

What types of changes does your code introduce to the Encrypted Computing SDK project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, paths needed to be updated

Copy link
Collaborator

@faberga faberga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherngutierrez christopherngutierrez merged commit cd3d340 into main Jun 10, 2025
8 checks passed
@christopherngutierrez christopherngutierrez deleted the christopherngutierrez/path-bug-fix branch June 10, 2025 18:02
christopherngutierrez added a commit that referenced this pull request Jun 10, 2025
Fixes two configuration files which contain the incorrect path to kerngen: .pre-commit-config.yaml and pytest.ini.
@faberga faberga added the bug Something isn't working label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants