Skip to content

Conversation

joserochh
Copy link
Contributor

@joserochh joserochh commented Jun 10, 2025

Proposed changes

Adding hec-assembler-tools to pre-commit and adding format checker to Github actions.

Types of changes

What types of changes does your code introduce to the Encrypted Computing SDK project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@joserochh joserochh added enhancement New feature or request Repo Configuration labels Jun 10, 2025
@joserochh joserochh marked this pull request as ready for review June 10, 2025 22:44
@joserochh joserochh changed the title Adding assembler folder to pre-commit check Adding CI format check & adding assembler to pre-commit Jun 10, 2025
Copy link
Collaborator

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@faberga faberga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@faberga
Copy link
Collaborator

faberga commented Jun 12, 2025

oops, this branch need rebasing with the main branch

@faberga faberga self-requested a review June 12, 2025 00:05
@joserochh joserochh merged commit eea0c13 into main Jun 12, 2025
8 of 9 checks passed
@joserochh joserochh deleted the joserochh/ci_format_check branch June 12, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Repo Configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants