Skip to content

Conversation

joserochh
Copy link
Contributor

@joserochh joserochh commented Jun 12, 2025

Proposed changes

Enabling Test Framework for the assembler + adding some initial basic unit tests for he_prep.py

Types of changes

What types of changes does your code introduce to the Encrypted Computing SDK project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

More unit tests to come gradually.

@joserochh joserochh marked this pull request as ready for review June 12, 2025 23:54
Copy link
Contributor

@christopherngutierrez christopherngutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test cases pass on my side. I added the assembler path in pytest.ini to allow pytest to run all test from root directory.

Copy link
Collaborator

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joserochh joserochh merged commit 018e2ed into main Jun 13, 2025
10 checks passed
@joserochh joserochh deleted the joserochh/assembler_testing branch June 13, 2025 16:07
@faberga faberga added the enhancement New feature or request label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants