-
Notifications
You must be signed in to change notification settings - Fork 4
Initial Enablement of Program Mapper Component #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b9b9dff
to
ce9d565
Compare
For the format action failing we can add an installation step for cpplint
Or perhaps we can have a requirements-dev.txt in the root with pytest, pylint and cpplint, which are not setup by the pre-commit-config.yml. And then reference this on CONTRIBUTING.md. So requirements-dev.txt can be something like:
|
I lean towards the latter. Other folks contributing will need those dependencies on their own system to do so anyway, and it avoids needing to edit the workflow every time a new dep pops up. Want to update the requirements as part of this PR or a separate one? |
Apparently as of v4, you can only have one "run" trigger per label unless you make the run itself a step... modifying to fix now |
@kylanerace , @joserochh and @christopherngutierrez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, initial commit of the Program Mapper.
If for this commit we are gonna stick with Ubuntu 22.04 then we need to change .github/workflows/format.yml line 13 to say I'm ok with sticking with 22.04 for this initial enablement. |
We set it to 24.04 because we were already effectively running it by using the default "ubuntu-latest" (actions pulls 24.04). So this change is purely to be more explicit, and to avoid GitHub actions updating to pull a different version potentially causing issues in the future. We've run code on both 22.04 and 24.04, though minimum required version is still assumed to be 22.04 by various components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally.
If we are already testing with 24.04, then let's change the README.md to reflect that. I will review that with a suggestion, and you can choose to accept. |
I'd want to avoid putting the latest version as 1. it's still not the primary system that we all use for development and 2. It will cause people to think they HAVE to update. I could see updating the README to say something to the effect of: Ubuntu 22.04+. But let's do general README documentation/updates in a separate PR, as there are a decent amount of other updates to do there anyway (only functional_modeler and program_mapper even mention OS-version requirements, probably will want a top-level README for p-isa to clarify build guidance, etc.) |
@kylanerace, that is good with me. |
Proposed changes
Types of changes
What types of changes does your code introduce to the Encrypted Computing SDK project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
N/A