Skip to content

Conversation

christopherngutierrez
Copy link
Contributor

Proposed changes

Fixed pylint in pre-commit-config.yaml for source-roots parameter. Removed PGM as there is no python code in that directory.

Types of changes

What types of changes does your code introduce to the Encrypted Computing SDK project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

None

@christopherngutierrez christopherngutierrez changed the title Christopherngutierrez/pre commit multi dir bug Bug Fix: Pylint source root in pre-commit-config Jun 17, 2025
@christopherngutierrez christopherngutierrez marked this pull request as ready for review June 17, 2025 21:03
Copy link
Collaborator

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherngutierrez christopherngutierrez merged commit 7f0bbed into main Jun 17, 2025
11 of 15 checks passed
@christopherngutierrez christopherngutierrez deleted the christopherngutierrez/pre-commit-multi-dir-bug branch June 17, 2025 21:23
@faberga faberga added the bug Something isn't working label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants