Skip to content

Conversation

w1th0utnam3
Copy link
Member

Implements

  • UniformQuadratureTable::to_general(&self, num_elements)
  • GeneralQuadratureTable::with_data(self, data)

@w1th0utnam3
Copy link
Member Author

Not sure what happened with CI here, maybe you can manually re-run it @Andlon?

@Andlon
Copy link
Member

Andlon commented Nov 14, 2022

Not sure what happened with CI here, maybe you can manually re-run it @Andlon?

Hmm, somehow I can't see anything about the CI at all, not sure what's happened here...

Copy link
Member

@Andlon Andlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks useful! Please see comments.

Some very basic tests would also be nice.

Copy link
Member

@Andlon Andlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I just still think that with_data_from_fn deserves a simple unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants