implemented a new service to be used in DCALIGN cooking, #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormation for AI training and validation
baltzell
requested changes
Dec 5, 2024
raffaelladevita
requested changes
Dec 5, 2024
etc/services/dcalign.yaml
Outdated
| name: RICH | ||
| - class: org.jlab.service.rtpc.RTPCEngine | ||
| name: RTPC | ||
| - class: org.jlab.service.mltn.MLDCEngine |
There was a problem hiding this comment.
dcalign.yaml is really only used for straight tracks/alignment runs. The new service should be added to data-ai.yaml or data-cv.yaml or data-aicv.yaml.
|
As soon as the changes to dcalign.yaml are reverted and #380 (review) is taken care of, this PR can be merged |
raffaelladevita
requested changes
Jan 30, 2025
| @@ -0,0 +1,159 @@ | |||
| /* | |||
There was a problem hiding this comment.
this is the commented text that should be removed
baltzell
previously approved these changes
Jan 30, 2025
raffaelladevita
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New banks in the output should help with ai training and validation