feat: add detector/run-number changed hook #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baltzell
changed the title
baltzell
changed the title
baltzell
force-pushed
the
detector-changed-hook
branch
from
ab928e3 to
468a286
Compare
baltzell
requested review from
Hattawy,
N-Plx,
ajhobart,
c-dilks,
drewkenjo,
efuchey,
forcar,
ftouchte,
hauenst,
heddle,
mathieuouillon,
mcontalb,
mpaolone,
raffaelladevita,
rafopar,
silvianic,
tongtongcao,
whit2333 and
zieglerv
as code owners
baltzell
force-pushed
the
detector-changed-hook
branch
from
468a286 to
5df7388
Compare
baltzell
changed the title
baltzell
force-pushed
the
detector-changed-hook
branch
from
5df7388 to
5066f0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support using real run numbers for simulation.
Includes DC2 support. Otherwise the same as #422
Same as #346. Closes #59.
Added abstract method detectorChanged(int run) to ReconstructionEngine, which is called automatically when the run number changes.
Moved every engine's geometry initialization from init or elsewhere to detectorChanged.
Changed the name of ReconstructionEngine's abstract event-processing method from processDataEvent to procesDataEventUser, and filterEvent to processDataEvent, such that all external uses of processDataEvent still do the right thing.
And removed EC's run number check per Cole.