Skip to content

Detector changed hook #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 48 commits into
base: development
Choose a base branch
from
Draft

Detector changed hook #905

wants to merge 48 commits into from

Conversation

@baltzell
Copy link
Collaborator

No description provided.

Nathan Baltzell and others added 30 commits October 23, 2025 18:12
@baltzell
remove unused stuff
bf105dc
@baltzell
add detectorChanged method (and remove unused imports)
e233a50
@baltzell
fix formatting
031b22a
@baltzell
implement all detectorChanged hooks (and cleanup/formatting)
179f381
@baltzell
synchronize and count changes
874fa59
@baltzell
allow nulls
aef38c7
@baltzell
add empty list check
078a62c
@baltzell
cleanup/formatting
c709834
@baltzell
use the same wrapper used in clara/recon-util
975c471
@baltzell
hardcode it to 11 for now
fffafa0
@baltzell
implement detectorChanged for cvt
ab3d519
@baltzell
implement detector changed for dc
7d3884c
@baltzell
use the same wrapper used in clara/recon-util
5842d98
@baltzell
fix logic oops
2bee916
@baltzell
rename processDataEvent/processEvent
178d963
@baltzell
make MLTDEngine respect run number like everyone else, unless overrid…
e0d08c9 
…en from YAML
@baltzell
add newly-required methods
66e6744
@baltzell
restore initialization
8cc0ab7
@baltzell
allow run number override from YAML
4979052
@baltzell
add missing overrides
ae65a8e
@baltzell
remove mc/data check
016da7b
@baltzell
test against gemc/dev
a0ce898
@baltzell
fix overrides (maintainence of never-ending PR)
8f0b9fe
@baltzell
processDataEvent should be final
bde9a0c
@baltzell
cleanup script
76134b5
@baltzell
remove unused/unnecessary script
146f1a7
@baltzell
disable workflow for now
51c1893
@baltzell
add neutron test
36ee460
@baltzell
remove leftovers
7bd964a
@baltzell
abort on error
a605b54
baltzell and others added 18 commits October 23, 2025 18:12
@baltzell
fix rebase mistake
1ef4420
@baltzell
add missing overrides
69b60f9
@baltzell
add missing overrides
2828cba
@baltzell
add missing overrides
ee11121
@raffaelladevita @baltzell
accounting for tstart, tflight and tprop in MC tracks reconstruction
6a988cf
@raffaelladevita @baltzell
removed check on run number when setting the DC hit uncertainty
75437d9
@raffaelladevita @baltzell
removed hardcoded change to default variation in BAND engine
3f2aca1
@raffaelladevita @baltzell
apply TDC jitter correction only if TI timestamp is >0, excluding MC …
fe44968 
…events
@raffaelladevita @baltzell
moved RF offsets to time written to RUN::rf bank
dd8ad3a
@raffaelladevita @baltzell
fixed bug in REC::Event.RFTime introduced with last commit
3e9b15d
@raffaelladevita @baltzell
restored TDC jitter correction for timestamp=0
67fa9c5
@raffaelladevita @baltzell
switch to load geometry for real run number
b44c905
@baltzell
fix env
46a35d8
@baltzell
add missing override
41f571c
@baltzell
remove unused imports
740fe4b
@baltzell
set PATH
c35fcf5
@baltzell
add missing overrides
84ed486
@baltzell
add missing overrides
bad311c
@baltzell baltzell added this to the Real Run Number Simulations milestone Oct 23, 2025
@baltzell baltzell added the gemc label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raffaelladevita raffaelladevita Awaiting requested review from raffaelladevita raffaelladevita will be requested when the pull request is marked ready for review raffaelladevita is a code owner

@c-dilks c-dilks Awaiting requested review from c-dilks c-dilks will be requested when the pull request is marked ready for review c-dilks is a code owner

@zieglerv zieglerv Awaiting requested review from zieglerv zieglerv will be requested when the pull request is marked ready for review zieglerv is a code owner

@tongtongcao tongtongcao Awaiting requested review from tongtongcao tongtongcao will be requested when the pull request is marked ready for review tongtongcao is a code owner

@mathieuouillon mathieuouillon Awaiting requested review from mathieuouillon mathieuouillon will be requested when the pull request is marked ready for review mathieuouillon is a code owner

@Hattawy Hattawy Awaiting requested review from Hattawy Hattawy will be requested when the pull request is marked ready for review Hattawy is a code owner

@drewkenjo drewkenjo Awaiting requested review from drewkenjo drewkenjo will be requested when the pull request is marked ready for review drewkenjo is a code owner

@mcontalb mcontalb Awaiting requested review from mcontalb mcontalb will be requested when the pull request is marked ready for review mcontalb is a code owner

@N-Plx N-Plx Awaiting requested review from N-Plx N-Plx will be requested when the pull request is marked ready for review N-Plx is a code owner

@rafopar rafopar Awaiting requested review from rafopar rafopar will be requested when the pull request is marked ready for review rafopar is a code owner

@forcar forcar Awaiting requested review from forcar forcar will be requested when the pull request is marked ready for review forcar is a code owner

@hauenst hauenst Awaiting requested review from hauenst hauenst will be requested when the pull request is marked ready for review hauenst is a code owner

@ajhobart ajhobart Awaiting requested review from ajhobart ajhobart will be requested when the pull request is marked ready for review ajhobart is a code owner

@silvianic silvianic Awaiting requested review from silvianic silvianic will be requested when the pull request is marked ready for review silvianic is a code owner

@mpaolone mpaolone Awaiting requested review from mpaolone mpaolone will be requested when the pull request is marked ready for review mpaolone is a code owner

@efuchey efuchey Awaiting requested review from efuchey efuchey will be requested when the pull request is marked ready for review efuchey is a code owner

@whit2333 whit2333 Awaiting requested review from whit2333 whit2333 will be requested when the pull request is marked ready for review whit2333 is a code owner

@ftouchte ftouchte Awaiting requested review from ftouchte ftouchte will be requested when the pull request is marked ready for review ftouchte is a code owner

@heddle heddle Awaiting requested review from heddle heddle will be requested when the pull request is marked ready for review heddle is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

gemc

Projects

None yet

Milestone

Real Run Number Simulations

Development

Successfully merging this pull request may close these issues.

3 participants

@baltzell @raffaelladevita