You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hole on track--defined as the layer where the track is projected to go through the sensitive area of a sensor but no hit is included in the track.
This is included in the Track object's _subdetId (see here Track). We already use this to account for the layer numbers with hits on track, setting _subdetId[layer]=1 for a hit on track. For a hole, I've set _subdetId[layer]=-1.
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Only comment: I'm not sure if it's the GitHub viewer, but it I'd be nice to intend your code after the definition of a method. Would be a lot easier to read.
That is weird, because in emacs these are indented correctly.
Looks good to me, thanks!
Only comment: I'm not sure if it's the GitHub viewer, but it I'd be nice to intend your code after the definition of a method. Would be a lot easier to read.
That is weird, because in emacs these are indented correctly.
Looks good to me, thanks!
Only comment: I'm not sure if it's the GitHub viewer, but it I'd be nice to intend your code after the definition of a method. Would be a lot easier to read.
Maybe run "untabify" in Emacs to turn tabs to spaces?
That is weird, because in emacs these are indented correctly.
Looks good to me, thanks!
Only comment: I'm not sure if it's the GitHub viewer, but it I'd be nice to intend your code after the definition of a method. Would be a lot easier to read.
Maybe run "untabify" in Emacs to turn tabs to spaces?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1147
Add hole on track--defined as the layer where the track is projected to go through the sensitive area of a sensor but no hit is included in the track.
This is included in the Track object's _subdetId (see here Track). We already use this to account for the layer numbers with hits on track, setting _subdetId[layer]=1 for a hit on track. For a hole, I've set _subdetId[layer]=-1.