handle complex datatype #57
Conversation
|
Any idea what the test failures are? https://buildkite.com/julialang/nccl-dot-jl/builds/36#0190cca1-710b-4b33-96b5-39d1fc64a262/303-1126 |
This looks unrelated to the pull request to me... did a configuration for the tests change since the last successful PR? |
|
The failure is the same with #58 and should be fixed with JuliaGPU/CUDA.jl#2457 |
|
Can we retrigger the build test now that JuliaGPU/CUDA.jl#2457 is merged? |
|
do a force push to your branch, it will retrigger the build. I don't have permissions |
|
That patch hasn't been released yet, we will have to wait till it is released |
|
Maybe we should also bump CUDA version to that patch once it is released |
|
Trying to get this issue resolved again now that the CUDA patch from earlier is released. Not sure if this build failure is my fault... any ideas @avik-pal @simonbyrne |
|
I think we need to bump the minimum julia versions in ci |
@avik-pal looks like julia 1.10 and above should work, do we want to drop support for 1.8 and 1.9 in this version? |
|
That's fine by me. |
Addresses #56. Tests added for ComplexF64.
Feedback appreciated.