-
Notifications
You must be signed in to change notification settings - Fork 11
fix: NCCL import of @checked
+ support for CUDA 13
#63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
src/libnccl.jl
Outdated
|
||
const NULL = C_NULL | ||
const INT_MIN = typemin(Cint) | ||
|
||
import CUDA: @checked, CuPtr, CUstream | ||
import CUDA: CuPtr, CUstream, @checked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this depend on a specific version of CUDA.jl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't this fixed by #60? Do we just need to make a new release? |
@maleadt any chance you can make a new release? (I don't have write access to this repo) |
Ah yes, I missed that (though we still want the changes to |
Good point. Can you rebase? |
I invited you to the JuliaGPU/CUDA team, which includes NCCL.jl. |
f1f62eb
to
54db9be
Compare
tests are failing because we are missing the cuda 13 builds for nccl. triggering one at JuliaPackaging/Yggdrasil#12061 |
b1a4dbd
to
3bdc737
Compare
Once JuliaRegistries/General#138616 lands we should have the proper JLLs |
@checked
@checked
+ support for CUDA 13
The current release fails with
https://buildkite.com/julialang/lux-dot-jl/builds/6534/steps/canvas?jid=019906f7-2982-40b8-8ff9-97e4675f0e15#019906f7-2982-40b8-8ff9-97e4675f0e15/356-890
cc @simonbyrne @kshyatt