Implement callback invoking on the NewPM API

[gbaraldi]

We can change the names here but I've tested that this works (maybe we could register a callback and see if it gets invoked?)

[github-actions]

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.

diff --git a/test/newpm.jl b/test/newpm.jl
index 68ae97c8..b2ea6070 100644
--- a/test/newpm.jl
+++ b/test/newpm.jl
@@ -409,31 +409,31 @@ end
     end
 end
 
-@testset "callbacks" begin
-    # just check that the callbacks can be registered and run without errors
-    @dispose ctx=Context() begin
-        # module callbacks
-        @dispose pb=NewPMPassBuilder() mod=test_module() begin
-            run!("PipelineStartCallbacks", mod) === nothing
-        end
-        @dispose pb=NewPMPassBuilder() mod=test_module() begin
-            run!(PipelineStartCallbacks(), mod) === nothing
-        end
-        # CGSCC callback
-        @dispose pb=NewPMPassBuilder() mod=test_module() begin
-            run!("CGSCCOptimizerLateCallbacks", mod) === nothing
-        end
-        @dispose pb=NewPMPassBuilder() mod=test_module() begin
-            run!(CGSCCOptimizerLateCallbacks(), mod) === nothing
-        end
-        # function callbacks
-        @dispose pb=NewPMPassBuilder() mod=test_module() begin
-            run!("PeepholeCallbacks", mod) === nothing
-        end
-        @dispose pb=NewPMPassBuilder() mod=test_module() begin
-            run!(PeepholeCallbacks(), mod) === nothing
+    @testset "callbacks" begin
+        # just check that the callbacks can be registered and run without errors
+        @dispose ctx = Context() begin
+            # module callbacks
+            @dispose pb = NewPMPassBuilder() mod = test_module() begin
+                run!("PipelineStartCallbacks", mod) === nothing
+            end
+            @dispose pb = NewPMPassBuilder() mod = test_module() begin
+                run!(PipelineStartCallbacks(), mod) === nothing
+            end
+            # CGSCC callback
+            @dispose pb = NewPMPassBuilder() mod = test_module() begin
+                run!("CGSCCOptimizerLateCallbacks", mod) === nothing
+            end
+            @dispose pb = NewPMPassBuilder() mod = test_module() begin
+                run!(CGSCCOptimizerLateCallbacks(), mod) === nothing
+            end
+            # function callbacks
+            @dispose pb = NewPMPassBuilder() mod = test_module() begin
+                run!("PeepholeCallbacks", mod) === nothing
+            end
+            @dispose pb = NewPMPassBuilder() mod = test_module() begin
+                run!(PeepholeCallbacks(), mod) === nothing
+            end
         end
     end
-end
 
 end

[vchuravy]

Would it make sense to open a PR upstream and ask for feedback?

[gbaraldi]

I think so.

But we also need this here anyway.

[vchuravy]

Sure, but before we commit to the API. Maybe we get lucky with a quick review ;)