-
Notifications
You must be signed in to change notification settings - Fork 4
Migrating to EzXML; adding pretty-printing #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmuchovej
wants to merge
10
commits into
JuliaPOMDP:master
Choose a base branch
from
jmuchovej:add-pretty-printing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
041b5fc
Migrating to EzXML; adding pretty-printing
jmuchovej 2138d8f
Cleaning up imports; checking tests
jmuchovej 68dce8f
Reorganize pretty printing; force use Base.string
jmuchovej d6891fa
Bringing impl closer to that of POMDPFiles
jmuchovej f6a4dfb
Typos in `var_name` access.
jmuchovej 77b9dd5
Forgot to remove `[s|a|o]name` params in `build_!` funcs
jmuchovej 2075bcb
EzXML wasn't imported correctly?
jmuchovej 63d063d
Forgot to `-1` on indices b/c C++ starts at 0.
jmuchovej 22e8b52
Add fallback values for unspecified T/O/R
jmuchovej c89cd65
Merge branch 'master' into add-pretty-printing
zsunberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
"""Parses a Policy XML file and returns `alphavectors` and `alphaactions` | ||
This should be able to handle any policy in the `.policy` format, which includes | ||
policies written by `POMDPs.jl` or `APPL`. | ||
|
||
`alphavectors` is a matrix containing the alpha vectors where each row corresponds to a | ||
different alpha vector. | ||
|
||
`alphaactions` is a vector containing the list of action indices, where ach index | ||
corresponds to action associated with the alpha vector row. | ||
These are `0-indexed`, so `0` maps to the first action. | ||
""" | ||
|
||
function read_pomdp(filename::String) | ||
xml = readxml(open(filename, "r")) | ||
policy = root(xml) # The <Polciy ..> node | ||
|
||
av_node = findfirst("AlphaVector", policy) | ||
|
||
alphavectors = Array{Real}[] | ||
alphaactions = [] | ||
|
||
# Create alpha vector and alpha action lists | ||
vectors = findall("Vector", av_node) | ||
for vector in vectors | ||
push!(alphavectors, parse.(Float64, split(nodecontent(vector)))) | ||
push!(alphaactions, vector["action"]) | ||
end | ||
alphavectors = transpose(mapreduce(permutedims, vcat, alphavectors)) | ||
|
||
n_vectors = parse(Int, av_node["numVectors"]) | ||
vector_len = parse(Int, av_node["vectorLength"]) | ||
@assert size(alphavectors) == (vector_len, n_vectors) | ||
|
||
# TODO handle sparsevectors | ||
sparsevectors = findall("SparseVector", av_node) | ||
for vector in sparsevectors | ||
# Turn these into vectors | ||
end | ||
|
||
return (alphavectors=alphavectors, alphaactions=parse.(Int64, alphaactions)) | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an exceedingly strange name for a function that reads in alpha vectors. I think we could name it something better and deprecate
read_pomdp
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was also confused by its name. 😅
Perhaps
read_policy
?Then
read_pomdp
(at some time TBD) would go from.pomdpx
toPOMDP
? Though I’m not sure the utility of this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like
read_policy
, but let's also have a deprecation for any downstream packages to transition smoothly.