-
Notifications
You must be signed in to change notification settings - Fork 3
removed mathematica testfiles not yet translated and improved documentation #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
removed mathematica testfiles not yet translated and improved documentation #23
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage ? 22.63%
=======================================
Files ? 20
Lines ? 4130
Branches ? 0
=======================================
Hits ? 935
Misses ? 3195
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I saw also that documentation build is failing. while I have this pr open I try to fix it |
ok documentation run is passing |
It would be good to have somewhere the ones that aren't translated are stored, just so there's a principled way to continue to improve this. Maybe as a separate branch? And document what the process is? |
yes that's a good idea. I already documented it a bit on the contributing page of the docs. In that new branch we could also add the Mathematica rule files so that it's easier to translate new rules. Can you create a new branch so that I can do the pr? i dont have permission to create one |
There is now an orphan branch called rules for this. |
I think is better to have in this branch also all the other code, rather than a empty repo. this is because the transaltion process involves also a lot of testing, and would be better to have full repo code to see if it's working on the spot, whitout needing to copy the file and change branch... also because the translation script that I wrote places the file in the exact folder needed. So it would just be more handy |
for this reason i am going to add the non-translated rules and also everything else to the |
Alright it's non-orphan now |
I forgot about it, but in the merge i left some mathematica files of the testsuite, not yet translated. With this pr i remove them. Documentation on how to translate them was already added here https://github.com/JuliaSymbolics/SymbolicIntegration.jl/blob/main/docs/src/manual/contributing.md#adding-testsuites