Skip to content

Conversation

Bumblebee00
Copy link
Contributor

I forgot about it, but in the merge i left some mathematica files of the testsuite, not yet translated. With this pr i remove them. Documentation on how to translate them was already added here https://github.com/JuliaSymbolics/SymbolicIntegration.jl/blob/main/docs/src/manual/contributing.md#adding-testsuites

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@de3c082). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage        ?   22.63%           
=======================================
  Files           ?       20           
  Lines           ?     4130           
  Branches        ?        0           
=======================================
  Hits            ?      935           
  Misses          ?     3195           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Bumblebee00
Copy link
Contributor Author

I saw also that documentation build is failing. while I have this pr open I try to fix it

@Bumblebee00 Bumblebee00 changed the title removed mathematica testfiles not yet translated removed mathematica testfiles not yet translated and improved documentation Sep 10, 2025
@Bumblebee00
Copy link
Contributor Author

ok documentation run is passing

@ChrisRackauckas
Copy link
Member

It would be good to have somewhere the ones that aren't translated are stored, just so there's a principled way to continue to improve this. Maybe as a separate branch? And document what the process is?

@Bumblebee00
Copy link
Contributor Author

yes that's a good idea. I already documented it a bit on the contributing page of the docs. In that new branch we could also add the Mathematica rule files so that it's easier to translate new rules. Can you create a new branch so that I can do the pr? i dont have permission to create one

@ChrisRackauckas
Copy link
Member

There is now an orphan branch called rules for this.

@Bumblebee00
Copy link
Contributor Author

I think is better to have in this branch also all the other code, rather than a empty repo. this is because the transaltion process involves also a lot of testing, and would be better to have full repo code to see if it's working on the spot, whitout needing to copy the file and change branch... also because the translation script that I wrote places the file in the exact folder needed. So it would just be more handy

@Bumblebee00
Copy link
Contributor Author

for this reason i am going to add the non-translated rules and also everything else to the rules branch, I hope you agree

@ChrisRackauckas
Copy link
Member

Alright it's non-orphan now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants