fix: more test/bug fixes

[AayushSabharwal]

No description provided.

[github-actions]

Benchmark Results (Julia v1)

Time benchmarks

	master	dc752bc...	master / dc752bc...
arithmetic/addition	0.0761 ± 0.0027 ms	0.0657 ± 0.00083 ms	1.16 ± 0.044
arithmetic/division	11 ± 0.43 μs	0.0354 ± 0.00066 ms	0.31 ± 0.013
arithmetic/multiplication	0.45 ± 0.014 ms	0.0475 ± 0.0017 ms	9.48 ± 0.45
overhead/acrule/a+2	5.98 ± 0.15 μs	2.2 ± 0.06 μs	2.71 ± 0.1
overhead/acrule/a+2+b	0.09 ± 0.009 μs	0.08 ± 0 μs	1.12 ± 0.11
overhead/acrule/a+b	9.63 ± 0.23 μs	3.77 ± 0.089 μs	2.56 ± 0.086
overhead/acrule/noop:Int	30 ± 0 ns	30 ± 0 ns	1 ± 0
overhead/acrule/noop:Sym	0.05 ± 0 μs	0.06 ± 0.001 μs	0.833 ± 0.014
overhead/get_degrees/large_poly	0.147 ± 0.01 s	0.0954 ± 0.0041 s	1.54 ± 0.12
overhead/rule/noop:Int	0.06 ± 0.001 μs	0.06 ± 0.009 μs	1 ± 0.15
overhead/rule/noop:Sym	0.06 ± 0 μs	0.06 ± 0.01 μs	1 ± 0.17
overhead/rule/noop:Term	0.06 ± 0 μs	0.06 ± 0.009 μs	1 ± 0.15
overhead/ruleset/noop:Int	0.17 ± 0.01 μs	30 ± 0 ns	5.67 ± 0.33
overhead/ruleset/noop:Sym	0.17 ± 0.001 μs	0.1 ± 0.01 μs	1.7 ± 0.17
overhead/ruleset/noop:Term	4.55 ± 0.19 μs	0.852 ± 0.02 μs	5.34 ± 0.26
overhead/simplify/noop:Int	0.27 ± 0.01 μs	30 ± 0 ns	9 ± 0.33
overhead/simplify/noop:Sym	0.271 ± 0.011 μs	0.05 ± 0 μs	5.42 ± 0.22
overhead/simplify/noop:Term	0.092 ± 0.011 ms	27 ± 0.55 μs	3.42 ± 0.41
overhead/simplify/randterm (+, *):serial	0.949 ± 0.045 s	0.244 ± 0.016 s	3.9 ± 0.32
overhead/simplify/randterm (+, *):thread	1.74 ± 0.32 s	0.244 ± 0.014 s	7.11 ± 1.4
overhead/simplify/randterm (/, *):serial	0.276 ± 0.026 ms	0.0777 ± 0.01 ms	3.55 ± 0.58
overhead/simplify/randterm (/, *):thread	0.316 ± 0.023 ms	0.0807 ± 0.012 ms	3.92 ± 0.67
overhead/substitute/a	0.0961 ± 0.01 ms	0.0414 ± 0.0029 ms	2.32 ± 0.3
overhead/substitute/a,b	0.0877 ± 0.0089 ms	0.0547 ± 0.0041 ms	1.6 ± 0.2
overhead/substitute/a,b,c	0.0687 ± 0.0033 ms	0.0525 ± 0.0017 ms	1.31 ± 0.075
polyform/easy_iszero	0.0392 ± 0.0038 ms	23.8 ± 0.41 μs	1.65 ± 0.16
polyform/isone	3.41 ± 0.059 ms	0.968 ± 0.017 ms	3.52 ± 0.087
polyform/isone:noop	30 ± 0 ns	0.07 ± 0.01 μs	0.429 ± 0.061
polyform/iszero	1.38 ± 0.029 ms	0.825 ± 0.017 ms	1.67 ± 0.05
polyform/iszero:noop	30 ± 0 ns	0.07 ± 0 μs	0.429 ± 0
polyform/simplify_fractions	1.88 ± 0.042 ms	1.08 ± 0.031 ms	1.75 ± 0.064
time_to_load	1.02 ± 0.0065 s	1.25 ± 0.016 s	0.817 ± 0.012

Memory benchmarks

	master	dc752bc...	master / dc752bc...
arithmetic/addition	1.06 k allocs: 0.0349 MB	0.469 k allocs: 13 kB	2.75
arithmetic/division	0.155 k allocs: 4.52 kB	0.231 k allocs: 6.33 kB	0.714
arithmetic/multiplication	5.83 k allocs: 0.168 MB	0.256 k allocs: 6.38 kB	27
overhead/acrule/a+2	0.061 k allocs: 2.09 kB	0.036 k allocs: 1.16 kB	1.81
overhead/acrule/a+2+b	0 allocs: 0 B	0 allocs: 0 B
overhead/acrule/a+b	0.09 k allocs: 3.19 kB	0.046 k allocs: 1.55 kB	2.06
overhead/acrule/noop:Int	0 allocs: 0 B	0 allocs: 0 B
overhead/acrule/noop:Sym	0 allocs: 0 B	0 allocs: 0 B
overhead/get_degrees/large_poly	1.45 M allocs: 0.0429 GB	0.601 M allocs: 18.9 MB	2.32
overhead/rule/noop:Int	2 allocs: 0.0625 kB	2 allocs: 0.0625 kB	1
overhead/rule/noop:Sym	2 allocs: 0.0625 kB	2 allocs: 0.0625 kB	1
overhead/rule/noop:Term	2 allocs: 0.0625 kB	2 allocs: 0.0625 kB	1
overhead/ruleset/noop:Int	4 allocs: 0.156 kB	0 allocs: 0 B
overhead/ruleset/noop:Sym	4 allocs: 0.156 kB	3 allocs: 0.109 kB	1.43
overhead/ruleset/noop:Term	0.063 k allocs: 2.33 kB	16 allocs: 0.453 kB	5.14
overhead/simplify/noop:Int	1 allocs: 0.0781 kB	0 allocs: 0 B
overhead/simplify/noop:Sym	1 allocs: 0.0781 kB	0 allocs: 0 B
overhead/simplify/noop:Term	0.677 k allocs: 28 kB	0.31 k allocs: 10.5 kB	2.66
overhead/simplify/randterm (+, *):serial	5.59 M allocs: 0.166 GB	2.32 M allocs: 0.0806 GB	2.07
overhead/simplify/randterm (+, *):thread	11.4 M allocs: 0.255 GB	2.35 M allocs: 0.0816 GB	3.13
overhead/simplify/randterm (/, *):serial	2.11 k allocs: 0.0779 MB	0.817 k allocs: 29 kB	2.75
overhead/simplify/randterm (/, *):thread	2.29 k allocs: 0.0839 MB	0.848 k allocs: 29.9 kB	2.87
overhead/substitute/a	0.807 k allocs: 26.7 kB	0.24 k allocs: 7 kB	3.81
overhead/substitute/a,b	0.715 k allocs: 23.6 kB	0.307 k allocs: 9.14 kB	2.58
overhead/substitute/a,b,c	0.551 k allocs: 17.6 kB	0.325 k allocs: 9.55 kB	1.84
polyform/easy_iszero	0.432 k allocs: 14.2 kB	0.166 k allocs: 4.36 kB	3.27
polyform/isone	0.0356 M allocs: 1.23 MB	12.3 k allocs: 0.724 MB	1.7
polyform/isone:noop	0 allocs: 0 B	0 allocs: 0 B
polyform/iszero	16 k allocs: 0.575 MB	9.6 k allocs: 0.589 MB	0.975
polyform/iszero:noop	0 allocs: 0 B	0 allocs: 0 B
polyform/simplify_fractions	19.7 k allocs: 0.71 MB	12.5 k allocs: 0.739 MB	0.962
time_to_load	0.159 k allocs: 11.2 kB	0.159 k allocs: 11.2 kB	1

[github-actions]

Benchmark Results (Julia vlts)

Time benchmarks

	master	92d4a17...	master / 92d4a17...
arithmetic/addition	0.0756 ± 0.0021 ms	0.0676 ± 0.00084 ms	1.12 ± 0.034
arithmetic/division	11.9 ± 0.49 μs	0.037 ± 0.00088 ms	0.32 ± 0.015
arithmetic/multiplication	0.49 ± 0.015 ms	0.0494 ± 0.0019 ms	9.91 ± 0.49
overhead/acrule/a+2	6.09 ± 0.31 μs	2.24 ± 0.05 μs	2.71 ± 0.15
overhead/acrule/a+2+b	0.1 ± 0.01 μs	0.07 ± 0.01 μs	1.43 ± 0.25
overhead/acrule/a+b	9.66 ± 0.42 μs	3.88 ± 0.13 μs	2.49 ± 0.14
overhead/acrule/noop:Int	0.05 ± 0.01 μs	0.05 ± 0.01 μs	1 ± 0.28
overhead/acrule/noop:Sym	0.05 ± 0.01 μs	0.05 ± 0.01 μs	1 ± 0.28
overhead/get_degrees/large_poly	0.172 ± 0.00073 s	0.11 ± 0.0055 s	1.56 ± 0.079
overhead/rule/noop:Int	0.07 ± 0 μs	0.06 ± 0.01 μs	1.17 ± 0.19
overhead/rule/noop:Sym	0.07 ± 0.01 μs	0.061 ± 0.01 μs	1.15 ± 0.25
overhead/rule/noop:Term	0.07 ± 0.01 μs	0.061 ± 0.01 μs	1.15 ± 0.25
overhead/ruleset/noop:Int	0.16 ± 0.001 μs	30 ± 0 ns	5.33 ± 0.033
overhead/ruleset/noop:Sym	0.17 ± 0.001 μs	0.101 ± 0.01 μs	1.68 ± 0.17
overhead/ruleset/noop:Term	4.71 ± 0.15 μs	0.812 ± 0.02 μs	5.8 ± 0.23
overhead/simplify/noop:Int	0.33 ± 0.049 μs	30 ± 0 ns	11 ± 1.6
overhead/simplify/noop:Sym	0.331 ± 0.05 μs	0.04 ± 0.01 μs	8.28 ± 2.4
overhead/simplify/noop:Term	0.0953 ± 0.0037 ms	28.1 ± 0.72 μs	3.4 ± 0.16
overhead/simplify/randterm (+, *):serial	0.903 ± 0.0086 s	0.271 ± 0.0066 s	3.34 ± 0.087
overhead/simplify/randterm (+, *):thread	0.909 ± 0.014 s	0.269 ± 0.0031 s	3.38 ± 0.066
overhead/simplify/randterm (/, *):serial	0.308 ± 0.019 ms	0.0817 ± 0.0018 ms	3.77 ± 0.25
overhead/simplify/randterm (/, *):thread	0.352 ± 0.02 ms	0.0856 ± 0.0018 ms	4.11 ± 0.25
overhead/substitute/a	0.0931 ± 0.0026 ms	0.0445 ± 0.001 ms	2.09 ± 0.075
overhead/substitute/a,b	0.0887 ± 0.0026 ms	0.0563 ± 0.0014 ms	1.58 ± 0.06
overhead/substitute/a,b,c	0.0692 ± 0.002 ms	0.0549 ± 0.0013 ms	1.26 ± 0.048
polyform/easy_iszero	0.042 ± 0.0013 ms	24.1 ± 0.48 μs	1.74 ± 0.063
polyform/isone	3.62 ± 0.13 ms	1.07 ± 0.025 ms	3.38 ± 0.14
polyform/isone:noop	30 ± 0 ns	0.07 ± 0.001 μs	0.429 ± 0.0061
polyform/iszero	1.5 ± 0.049 ms	0.929 ± 0.05 ms	1.62 ± 0.1
polyform/iszero:noop	30 ± 0 ns	0.07 ± 0.01 μs	0.429 ± 0.061
polyform/simplify_fractions	2.01 ± 0.066 ms	1.24 ± 0.13 ms	1.63 ± 0.18
time_to_load	0.954 ± 0.018 s	1.2 ± 0.04 s	0.796 ± 0.031

Memory benchmarks

	master	92d4a17...	master / 92d4a17...
arithmetic/addition	1.05 k allocs: 0.0366 MB	0.439 k allocs: 12.5 kB	2.99
arithmetic/division	0.156 k allocs: 4.84 kB	0.205 k allocs: 5.89 kB	0.822
arithmetic/multiplication	5.87 k allocs: 0.18 MB	0.258 k allocs: 6.38 kB	29
overhead/acrule/a+2	0.056 k allocs: 2.09 kB	0.034 k allocs: 1.19 kB	1.76
overhead/acrule/a+2+b	0 allocs: 0 B	0 allocs: 0 B
overhead/acrule/a+b	0.081 k allocs: 3.19 kB	0.043 k allocs: 1.61 kB	1.98
overhead/acrule/noop:Int	0 allocs: 0 B	0 allocs: 0 B
overhead/acrule/noop:Sym	0 allocs: 0 B	0 allocs: 0 B
overhead/get_degrees/large_poly	1.45 M allocs: 0.0429 GB	0.601 M allocs: 18.9 MB	2.32
overhead/rule/noop:Int	2 allocs: 0.0625 kB	2 allocs: 0.0625 kB	1
overhead/rule/noop:Sym	2 allocs: 0.0625 kB	2 allocs: 0.0625 kB	1
overhead/rule/noop:Term	2 allocs: 0.0625 kB	2 allocs: 0.0625 kB	1
overhead/ruleset/noop:Int	4 allocs: 0.156 kB	0 allocs: 0 B
overhead/ruleset/noop:Sym	4 allocs: 0.156 kB	3 allocs: 0.109 kB	1.43
overhead/ruleset/noop:Term	0.059 k allocs: 2.34 kB	14 allocs: 0.422 kB	5.56
overhead/simplify/noop:Int	1 allocs: 0.0781 kB	0 allocs: 0 B
overhead/simplify/noop:Sym	1 allocs: 0.0781 kB	0 allocs: 0 B
overhead/simplify/noop:Term	0.619 k allocs: 28 kB	0.29 k allocs: 10.9 kB	2.57
overhead/simplify/randterm (+, *):serial	5.21 M allocs: 0.166 GB	2.2 M allocs: 0.0825 GB	2.01
overhead/simplify/randterm (+, *):thread	5.37 M allocs: 0.171 GB	2.27 M allocs: 0.0847 GB	2.02
overhead/simplify/randterm (/, *):serial	2.05 k allocs: 0.0783 MB	0.778 k allocs: 28.7 kB	2.79
overhead/simplify/randterm (/, *):thread	2.21 k allocs: 0.0841 MB	0.813 k allocs: 29.8 kB	2.89
overhead/substitute/a	0.754 k allocs: 26.9 kB	0.221 k allocs: 6.45 kB	4.17
overhead/substitute/a,b	0.666 k allocs: 23.8 kB	0.285 k allocs: 8.17 kB	2.91
overhead/substitute/a,b,c	0.514 k allocs: 17.7 kB	0.289 k allocs: 7.86 kB	2.25
polyform/easy_iszero	0.423 k allocs: 15.1 kB	0.153 k allocs: 4.09 kB	3.68
polyform/isone	0.0327 M allocs: 1.28 MB	8.61 k allocs: 0.72 MB	1.78
polyform/isone:noop	0 allocs: 0 B	0 allocs: 0 B
polyform/iszero	14.3 k allocs: 0.598 MB	7.24 k allocs: 0.596 MB	1
polyform/iszero:noop	0 allocs: 0 B	0 allocs: 0 B
polyform/simplify_fractions	17.7 k allocs: 0.75 MB	9.42 k allocs: 0.745 MB	1.01
time_to_load	0.153 k allocs: 14.5 kB	0.153 k allocs: 14.5 kB	1