Skip to content

Handling error for sync true #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2025
Merged

Handling error for sync true #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b5a7a0f
pass lsrs response as it is to sdk in case of error
Nick-1234531 Nov 3, 2025
de055c6
sending err msg
Nick-1234531 Nov 6, 2025
525f400
setting SS status in case of still processing
Nick-1234531 Nov 6, 2025
55fc811
version bump
Nick-1234531 Nov 7, 2025
914096f
resolved merge conflict
Nick-1234531 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lambdatest/smartui-cli",
"version": "4.1.42-beta.0",
"version": "4.1.42",
"description": "A command line interface (CLI) to run SmartUI tests on LambdaTest",
"files": [
"dist/**/*"
Expand Down
18 changes: 7 additions & 11 deletions src/lib/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,10 @@ export default async (ctx: Context): Promise<FastifyInstance<Server, IncomingMes

if (externalResponse.statusCode === 200) {
replyCode = 200;
replyBody = externalResponse.data;
replyBody = {
data: externalResponse.data,
error: externalResponse.error.message
}
return reply.code(replyCode).send(replyBody);
} else if (externalResponse.statusCode === 202 ) {
replyBody= externalResponse.data;
Expand All @@ -306,13 +309,7 @@ export default async (ctx: Context): Promise<FastifyInstance<Server, IncomingMes
}else {
ctx.log.debug(`Unexpected response from external API: ${JSON.stringify(externalResponse)}`);
replyCode = 500;
replyBody = {
error: {
message: `Unexpected response from external API: ${externalResponse.statusCode}`,
externalApiStatus: externalResponse.statusCode
}
};
return reply.code(replyCode).send(replyBody);
return reply.code(replyCode).send(externalResponse);
}

ctx.log.debug(`timeoutDuration: ${timeoutDuration}`);
Expand All @@ -321,9 +318,8 @@ export default async (ctx: Context): Promise<FastifyInstance<Server, IncomingMes
if (Date.now() - startTime > timeoutDuration) {
replyCode = 202;
replyBody = {
data: {
message: 'Request timed out-> Snapshot still processing'
}
error: 'Request timed out, Snapshot still processing',
data: lastExternalResponse.data
};
return reply.code(replyCode).send(replyBody);
}
Expand Down