Skip to content

Conversation

laundy
Copy link

@laundy laundy commented Sep 6, 2025

First of all: Incredible work, I use the package a lot! 🤩

I've noticed that the option page is not localizable yet, so I've just added the necessary functionality. Also, I've included the $position in the options.stub and added a hint for developers to change the $position, otherwise only one (or none) will be displayed.

Please also test the code and I'd be happy if the change gets merged.

@Log1x
Copy link
Owner

Log1x commented Sep 18, 2025

Hey! Thanks for this. I'm glad you like ACF Composer.

Everything looks good, but would you mind dropping the// TODO: change to another value if you have multiple option pages. comment from the stubs? 👀 I'd be open to something in stub generation that auto-iterates that value in the future but otherwise just not huge on the inline comment.

@laundy
Copy link
Author

laundy commented Sep 18, 2025

Thanks for your feedback. Sure, the todo comments are removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants