-
Notifications
You must be signed in to change notification settings - Fork 371
Fix JSON structure in model context protocol REST API samples and add required python packages #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@horihiro : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit ed4c36b: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 4f8104c: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit e9cd505: ✅ Validation status: passed
For more details, please refer to the build report. |
|
@aahill - Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
|
Learn Build status updates of commit 7aa7465: ✅ Validation status: passed
For more details, please refer to the build report. |
|
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes JSON formatting issues in Model Context Protocol REST API code samples and adds documentation for required Python packages. The changes improve the accuracy and usability of the documentation by correcting syntax errors and providing essential setup information.
- Corrected JSON structure issues including quotation marks, trailing commas, and indentation
- Added note specifying required Python package versions for running sample code
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "mcp": [ | ||
| { | ||
| "server_label": "<the same unique name you provided during agent creation>", | ||
| "require_approval": "always", #always by default |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON does not support comments with #. Consider removing the comment or moving it outside the JSON structure to maintain valid JSON syntax.
| "require_approval": "always", #always by default | |
| "require_approval": "always", |
| "type": "mcp", | ||
| "server_label": "<unique name for your MCP server>", | ||
| "server_url": "<your MCP server URL>", | ||
| "allowed_tools": ["<tool_name>"] # optional |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON does not support comments with #. Consider removing the comment or moving it outside the JSON structure to maintain valid JSON syntax.
| "allowed_tools": ["<tool_name>"] # optional | |
| "allowed_tools": ["<tool_name>"] |
Uh oh!
There was an error while loading. Please reload this page.