Skip to content

Conversation

@horihiro
Copy link

@horihiro horihiro commented Sep 20, 2025

  • Fix quotation characters, tailing comma and some indents
  • Add a description of the Python packages required to run the sample code

@prmerger-automator
Copy link
Contributor

@horihiro : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit ed4c36b:

✅ Validation status: passed

File Status Preview URL Details
articles/ai-foundry/agents/how-to/tools/model-context-protocol-samples.md ✅Succeeded

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 4f8104c:

✅ Validation status: passed

File Status Preview URL Details
articles/ai-foundry/agents/how-to/tools/model-context-protocol-samples.md ✅Succeeded

For more details, please refer to the build report.

@horihiro horihiro changed the title Fix JSON structure in model context protocol REST API samples Fix JSON structure in model context protocol REST API samples and add required python packages Sep 22, 2025
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit e9cd505:

✅ Validation status: passed

File Status Preview URL Details
articles/ai-foundry/agents/how-to/tools/model-context-protocol-samples.md ✅Succeeded

For more details, please refer to the build report.

@v-regandowner
Copy link
Contributor

@aahill - Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Sep 22, 2025
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 7aa7465:

✅ Validation status: passed

File Status Preview URL Details
articles/ai-foundry/agents/how-to/tools/model-context-protocol-samples.md ✅Succeeded

For more details, please refer to the build report.

@github-actions
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Oct 17, 2025
@v-dirichards v-dirichards requested a review from Copilot October 17, 2025 14:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes JSON formatting issues in Model Context Protocol REST API code samples and adds documentation for required Python packages. The changes improve the accuracy and usability of the documentation by correcting syntax errors and providing essential setup information.

  • Corrected JSON structure issues including quotation marks, trailing commas, and indentation
  • Added note specifying required Python package versions for running sample code

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

"mcp": [
{
"server_label": "<the same unique name you provided during agent creation>",
"require_approval": "always", #always by default
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON does not support comments with #. Consider removing the comment or moving it outside the JSON structure to maintain valid JSON syntax.

Suggested change
"require_approval": "always", #always by default
"require_approval": "always",

Copilot uses AI. Check for mistakes.
"type": "mcp",
"server_label": "<unique name for your MCP server>",
"server_url": "<your MCP server URL>",
"allowed_tools": ["<tool_name>"] # optional
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON does not support comments with #. Consider removing the comment or moving it outside the JSON structure to maintain valid JSON syntax.

Suggested change
"allowed_tools": ["<tool_name>"] # optional
"allowed_tools": ["<tool_name>"]

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aq-pr-triaged C+L Pull Request Review Team label azure-ai-agent-service/svc Change sent to author do-not-merge inactive This PR is inactive for more than 14 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants