Skip to content

Conversation

@radubulboaca
Copy link

Add get-csaiagents

@learn-build-service-prod
Copy link

Learn Build status updates of commit 1263d95:

⚠️ Validation status: warnings

File Status Preview URL Details
teams/teams-ps/MicrosoftTeams/MicrosoftTeams.md ⚠️Warning View (teams-ps) Details
teams/teams-ps/MicrosoftTeams/Get-CsAiAgents.md ✅Succeeded View (teams-ps)

teams/teams-ps/MicrosoftTeams/MicrosoftTeams.md

  • Line 0, Column 0: [Warning: PSMD2Yaml_InconsistentCmdletsInModule] Inconsistent cmdlets found in module: MicrosoftTeams. 1 cmdlets in the module folder but not listed in the module file: Get-CsAiAgents.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 3eb4e8a:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/MicrosoftTeams/Get-CsAiAgents.md ✅Succeeded View (teams-ps)
teams/teams-ps/MicrosoftTeams/MicrosoftTeams.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 285833d:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/MicrosoftTeams/Get-CsAiAgents.md ✅Succeeded View (teams-ps)
teams/teams-ps/MicrosoftTeams/MicrosoftTeams.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Copy link
Member

@nomorephones nomorephones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The synopsis doesn't articulate the purpose of ProviderID. Suggest amendind with "...in the tenant that match with the ProviderID.

  2. In the spec, ProviderID is an array allowing for a return of Agents across multiple ProviderIDs. If that's supported in this version, suggest including an example.

  3. In the past, I've seen the output of cmdlets as a complex object type. For example, with CsTagsTemplate the output is a "Microsoft.Rtc.Management.Hosted.CallQueue.Models.CallQueue". While the example is definitely appreciated, I'm curious if this still follows the convention.

  4. If the GUIDs here are from a real environment, suggest bit-shifting a character by a value or two to obfuscate it.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 8c384b3:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/MicrosoftTeams/Get-CsAiAgents.md ✅Succeeded View (teams-ps)
teams/teams-ps/MicrosoftTeams/MicrosoftTeams.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

@learn-build-service-prod
Copy link

Learn Build status updates of commit dc85378:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/MicrosoftTeams/Get-CsAiAgents.md ✅Succeeded View (teams-ps)
teams/teams-ps/MicrosoftTeams/MicrosoftTeams.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

@radubulboaca
Copy link
Author

The synopsis doesn't articulate the purpose of ProviderID. Suggest amendind with "...in the tenant that match with the ProviderID.

Thanks, updated.

In the spec, ProviderID is an array allowing for a return of Agents across multiple ProviderIDs. If that's supported in this version, suggest including an example.

Thanks, added another example

In the past, I've seen the output of cmdlets as a complex object type. For example, with CsTagsTemplate the output is a "Microsoft.Rtc.Management.Hosted.CallQueue.Models.CallQueue". While the example is definitely appreciated, I'm curious if this still follows the convention.

We're a bit uncertain of what the namespace will be for this one. I'll keep this as is for now and make an update once I verify it

If the GUIDs here are from a real environment, suggest bit-shifting a character by a value or two to obfuscate it.

Thanks, already randomized some of the fields, I randomized more of them now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants