NOISSUE Fix valid account check when starting instance #5648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a missing space and remove "Mojang account" since these are no longer supported.
… on the "no valid account" message box
JoelTroch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to phit on Discord for reporting the first issue and doing the initial investigation.
This PR fixes three issues:
About the fix for issue number 1: I tried a more "elegant fix" by getting rid of the "dummy" account that is created when MultiMC starts but I went into issues like crashes with an account is already set up. I'm not very familiar with MultiMC's codebase so I went with the hypothesis that this "dummy" account was "needed" and I went with the alternative that you see in this PR.
If this PR should have been divided into three distinct PRs, let me know and I'll split them.