Print perfdata to normal output #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 5, 2025 12:22
Fix on 181ad1f, which limits printing of perf data to only the last set of data. However, the guard incorrectly restricts the printing to cases where we have at least two, not at least one.
This way, notifications get more than just a "InfluxDB Query Status" but instead get a InfluxDB Query Status power=20.883;8:75;5: or InfluxDB Query Status temperature=6.2;12;15
|
Hi, thanks for the PR. I'm not sure yet if this is behavior we want to introduce. @RincewindsHat any thoughts? |
|
I do not really like the aesthetics here (I feel like it is hard to read), but the change has little impact on the code complexity. |
|
I'm not sure about the change. I think the use case is too narrow, aren't there macros to get this data for a notification plugin? And for the Icinga Web, in icingadb-web the perfdata are visible in various panels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really find it helpful if my icinga notifications give me some insight on how outside the expected range a datapoint falls.
It seems the easiest approach is to just repeat the perdata in the "plain text" part of the output as well, so it gets picked up by my notification scripts as well as the icingaweb default output.
e.g.:
(This is on top of pull-request #37.)