Add option to enable and disable feeds #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSyscall
requested changes
Oct 2, 2025
| } | ||
|
|
||
| // Skip inactive feeds | ||
| if (!$feed->isActive) { |
There was a problem hiding this comment.
That makes it impossible to request a feed by it's name.
Like: feeds=feedA,feedB where feedB is disabled.
But the same behaviour is not implemented for requesting a single feed.
Is that intentional?
There was a problem hiding this comment.
Yeah somewhat, but I'm fine with having the same behavior in the FeedController.
Probably that's a bit more expected
There was a problem hiding this comment.
My idea would be to still show it if the user explicitly requests it.
Aka. $feeds !== null
There was a problem hiding this comment.
Feel free to update the branch if you want to work on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51